Thanks, changes updated. I also added the drm parameter to the readme on the 2.8" capacitive and 2.2" displays.

There is one line left with spaces for indentation

WARNING: please, no spaces at the start of a line
#76: FILE: arch/arm/boot/dts/overlays/pitft22-overlay.dts:10:
+    compatible = "brcm,bcm2835";$

Up to @pelwell whether he's fussed over the spaces. Overlays will never get upstreamed, so it's not as critical.

Note 1: Generally we want the commits as they are to be merged, so fixups should be squashed into the base patch, or use git commit --amend to modify it. You then need git push -f ... when pushing to update the branch on Github.
We can squash all commits of a PR into one which would work in this case, but that's not always the desired result.

Note 2: any patches to drivers or anything that may need to be upstreamed really need to have a Signed-off-by: line. See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin for what that means, but it can be done simply by using git commit -s when generating your patch.

Oh yeah, thanks. Spacing fixed now.
Is it too late to combine the previous commits?

Ok, signed-off by line added too.

Oh yeah, thanks. Fixed now. Is it too late to combine the previous commits?

Nothing has been merged yet, so you can modify your branch as much as you want to reflect what you are proposing to merge. You can therefore use git rebase -i or similar to edit your branch, squash things together, alter commit messages, etc, and then push an updated branch.

Ok, had to do it with a case-sensitive filesystem, but success.

Added commit description because it was failing without one.

All the touch-size parameters are targeting integer properties, but they're written as if they're targeting booleans - you need:

		touch-sizex = <&ft6236>,"touchscreen-size-x:0";

Also, it bothers me that the documentation says the sizes have default values, but those defaults are not present in the overlay - the stmpe_touchscreen nodes don't seem to include any of the touchscreen- properties unless the parameters are used.

1. The fact that the various size properties are broken makes me think this hasn't been tested. Are you sure that the touchscreen- properties are recognised by the driver?
2. Are the defaults quoted in the README correct?

I'm sure that at least the invert and swap ones are recognized as I have modified those. They are part of linux/input/touchscreen.h and I believe they are read when touchscreen_parse_properties() is called.

And are the default sizes as given in the README?

Sorry, was looking it up still. The defaults for 3.5" should be 320 x 480. However, I think they may not be so useful when applied to the resistive touchscreens, so I could remove those. I really only needed the inverts and swap params.

Ok, updated the 3.5" size at least.

Ok, I see the capacitive one (which I got them from) has defaults, but not the new ones. I should either add default sizes to the overlays or remove them. What do you think?

Actually, I'll test to see if adding the defaults messes up anything and if so, I'll just remove them. If not, I'll see if changing has any effect. If not, I'll remove them.

I'm happy for you to use any defaults or not, as you wish, provided it works as described.

Ok, was getting some strange results on the Resistive PiTFTs (negative values) with defaults added, so I removed the size ones. I fixed the overrides on the capacitive display and updated the README to reflect those changes.

That looks better (on a phone, will check properly before merging when the build checks complete). Don't worry about the commit description line length - it will get squashed into the monolithic DT commit anyway.

Thanks!